Skip to content

ADR β€” PR #1007

2026-05-18 21:10 β€” Address ambiguous selector in rate-limiting.astro

Section titled β€œ2026-05-18 21:10 β€” Address ambiguous selector in rate-limiting.astro”
  • Comment: CodeRabbit comment thread
  • Priority: must-fix
  • Decision: accept
  • Rationale: The selector .text-crimson-600 was ambiguous after migrating both stat cards to the crimson theme. Extended AdminStatCard to accept a unique id and dataStat prop (to fix invalid {label | slug} pattern) and updated rate-limiting.astro to use document.getElementById('blocked-ips-count').

2026-05-18 21:15 β€” Add ARIA state to rail toggle button

Section titled β€œ2026-05-18 21:15 β€” Add ARIA state to rail toggle button”
  • Comment: CodeRabbit comment thread
  • Priority: must-fix
  • Decision: accept
  • Rationale: The toggle button was missing aria-expanded state. Added the attribute and updated the script to sync it with the rail’s expanded state.

2026-05-18 21:20 β€” Move rail state management to client component

Section titled β€œ2026-05-18 21:20 β€” Move rail state management to client component”
  • Comment: CodeRabbit comment thread
  • Priority: nice-to-have
  • Decision: reject
  • Rationale: The current implementation is simple and performant. Converting to a client component would require moving significant markup to React, which could introduce regressions and is disproportionate for a simple toggle behavior.