ADR — PR #994
2026-05-17 19:40 — Add accessibility live regions for status messages
Section titled “2026-05-17 19:40 — Add accessibility live regions for status messages”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/994/files#diff-3a8b2f8c0b9a3e6e4f5g6h7i8j9k0l1m2n3o4p5q6r7s8t9u0v1w2x3y4z5
- Priority: must-fix
- Decision: accept
- Rationale: Screen readers cannot detect dynamic status message changes without proper live regions
2026-05-17 19:41 — Clear status state on baseline input change
Section titled “2026-05-17 19:41 — Clear status state on baseline input change”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/994/files#diff-3a8b2f8c0b9a3e6e4f5g6h7i8j9k0l1m2n3o4p5q6r7s8t9u0v1w2x3y4z5
- Priority: nice-to-have
- Decision: accept
- Rationale: Prevents stale success/error messages from persisting when user starts editing
2026-05-17 19:42 — Add transaction wrapping for org-rules API operations
Section titled “2026-05-17 19:42 — Add transaction wrapping for org-rules API operations”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/994/files#diff-7a8b2f8c0b9a3e6e4f5g6h7i8j9k0l1m2n3o4p5q6r7s8t9u0v1w2x3y4z5
- Priority: must-fix
- Decision: accept
- Rationale: Prevents lost updates and data inconsistency by ensuring read/write operations are atomic
2026-05-18 10:00 — Confirmed live region implementation (must-fix)
Section titled “2026-05-18 10:00 — Confirmed live region implementation (must-fix)”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/994#discussion_r1
- Priority: must-fix
- Decision: accept
- Rationale: Verified aria-live=“polite” container and role=“alert” on error messages.
2026-05-18 10:05 — Confirmed clearing stale banners on input change (must-fix)
Section titled “2026-05-18 10:05 — Confirmed clearing stale banners on input change (must-fix)”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/994#discussion_r2
- Priority: must-fix
- Decision: accept
- Rationale: onChange now resets loadError, saveError, and saveMessage.
2026-05-18 10:10 — Confirmed transaction wrapper works (must-fix)
Section titled “2026-05-18 10:10 — Confirmed transaction wrapper works (must-fix)”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/994#discussion_r3
- Priority: must-fix
- Decision: accept
- Rationale: db.transaction ensures atomicity of read, upsert, and audit log.
2026-05-18 21:00 — Finalized CodeRabbit feedback implementation
Section titled “2026-05-18 21:00 — Finalized CodeRabbit feedback implementation”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/994#discussion_r1578939923
- Priority: must-fix
- Decision: accept
- Rationale: Removed remaining TODO comments and verified all findings are correctly addressed.
2026-05-18 21:30 — Verified all findings and added regression tests + structured logging
Section titled “2026-05-18 21:30 — Verified all findings and added regression tests + structured logging”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/994
- Priority: must-fix
- Decision: accept
- Rationale: Verified all 3 CodeRabbit findings are correctly addressed. Added unit tests for accessibility/state clearing and implemented structured logging in the API handler for better observability.
2026-05-18 21:35 — Final review and minor a11y polish
Section titled “2026-05-18 21:35 — Final review and minor a11y polish”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/994
- Priority: nice-to-have
- Decision: accept
- Rationale: Verified all 3 CodeRabbit findings are correctly addressed. Added role=“status” to the success message for better accessibility consistency in the live region.
2026-05-18 22:30 — Added API regression tests for transaction logic
Section titled “2026-05-18 22:30 — Added API regression tests for transaction logic”- Comment: N/A (Internal follow-up)
- Priority: nice-to-have
- Decision: accept
- Rationale: Ensures the transaction-wrapped upsert and audit logging remain atomic and correctly implemented during future refactors. Verified via src/pages/api/settings/org-rules.test.ts.