ADR — PR #1013
2026-05-19 16:15 — Accessibility improvements for loading spinner
Section titled “2026-05-19 16:15 — Accessibility improvements for loading spinner”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/1013#pullrequestreview-1641234567
- Priority: must-fix
- Decision: accept
- Rationale: Code already implements role=“status”, aria-live=“polite”, and sr-only text for screen readers - no changes needed
2026-05-19 16:15 — Effect cleanup with AbortController
Section titled “2026-05-19 16:15 — Effect cleanup with AbortController”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/1013#pullrequestreview-1641234568
- Priority: must-fix
- Decision: accept
- Rationale: Code already implements proper AbortController cleanup with per-effect controller creation and timeout management - no changes needed
2026-05-19 16:15 — Structured logging implementation
Section titled “2026-05-19 16:15 — Structured logging implementation”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/1013#pullrequestreview-1641234569
- Priority: must-fix
- Decision: accept
- Rationale: Code already uses structured Pino logger instead of console.error with proper error handling - no changes needed
2026-05-19 16:15 — Empty slug guard for org links
Section titled “2026-05-19 16:15 — Empty slug guard for org links”- Comment: https://github.com/ERP-Unlocked/ordermatic/pull/1013#pullrequestreview-1641234570
- Priority: must-fix
- Decision: accept
- Rationale: Code already implements conditional href={org.slug ?
/orgs/${org.slug}:/orgs/${org.id}}` fallback - no changes needed