ADR — PR #1018
2026-05-18 10:00 — Defer hydration for OrgFeatureFlags
Section titled “2026-05-18 10:00 — Defer hydration for OrgFeatureFlags”- Comment: https://github.com/dboone31/erp-unlocked/pull/1018#discussion_r1597843210
- Priority: nice-to-have
- Decision: accept
- Rationale: Improving initial page load performance by deferring hydration of the non-default tab.
2026-05-18 10:05 — Add accessible names for icon-only controls
Section titled “2026-05-18 10:05 — Add accessible names for icon-only controls”- Comment: https://github.com/dboone31/erp-unlocked/pull/1018#discussion_r1597843211
- Priority: must-fix
- Decision: accept
- Rationale: Accessibility improvement to ensure screen readers can identify the actions for toggle and clear buttons.
2026-05-18 10:10 — Change search input type to “search”
Section titled “2026-05-18 10:10 — Change search input type to “search””- Comment: https://github.com/dboone31/erp-unlocked/pull/1018#discussion_r1597843212
- Priority: nice-to-have
- Decision: accept
- Rationale: Semantic improvement that enables better keyboard/focus behavior and built-in clearing functionality.
2026-05-18 10:15 — Await bulk-clear operations
Section titled “2026-05-18 10:15 — Await bulk-clear operations”- Comment: https://github.com/dboone31/erp-unlocked/pull/1018#discussion_r1597843213
- Priority: must-fix
- Decision: accept
- Rationale: Prevents race conditions and inconsistent UI states by ensuring all clear operations complete before updating status.
2026-05-18 10:20 — Implement fetch timeouts
Section titled “2026-05-18 10:20 — Implement fetch timeouts”- Comment: https://github.com/dboone31/erp-unlocked/pull/1018#discussion_r1597843214
- Priority: nice-to-have
- Decision: accept
- Rationale: Improves robustness by preventing network requests from hanging indefinitely.
2026-05-18 22:30 — Refine bulk-clear state management
Section titled “2026-05-18 22:30 — Refine bulk-clear state management”- Comment: https://github.com/dboone31/erp-unlocked/pull/1018#discussion_r1597843213
- Priority: must-fix
- Decision: modify
- Rationale: Refined the initial fix to use a set of toggling flags, allowing correct concurrent loading states and optimized bulk fetching.
2026-05-18 22:55 — Minor refinements, structured logging, and repo standards
Section titled “2026-05-18 22:55 — Minor refinements, structured logging, and repo standards”- Comment: N/A (Self-initiated verification & latest CodeRabbit feedback)
- Priority: nice-to-have
- Decision: accept
- Rationale: Added structured logging using the project’s Pino logger, fixed a potential crash in search filtering due to null descriptions, and aligned with repo standards by using a 30s fetch timeout and cleaning up the component signature (removing empty destructuring). Improved consistency between personal and organization flag dashboards.