ADR — PR #2127

2026-07-04 20:50 — Address CodeRabbit feedback for PR #2127

• Comment: MIGRATION_STATUS.md - Phase numbering (cr-comment:v1:3483d3b4dd653f56320337e5)

• Priority: nice-to-have

• Decision: accept

• Rationale: Renamed Phase 1-4 to Step 1-4 in the Phase 2b checklist to avoid confusion with the section’s outer Phase headings.

• Comment: hetzner-final-dump.sh - pipefail and error propagation

• Priority: must-fix

• Decision: accept

• Rationale: Added set -o pipefail to ensure that failures in the pg_dumpall | gzip pipeline are properly caught.

• Comment: hetzner-final-dump.sh - Cleanup on failure (trap)

• Priority: must-fix

• Decision: accept

• Rationale: Added an EXIT trap to ensure that temporary dump files and .pgpass files are removed regardless of script success or failure.

• Comment: hetzner-final-dump.sh - PGPASSWORD exposure

• Priority: must-fix

• Decision: accept

• Rationale: Refactored the docker run command to use a temporary .pgpass file mounted as a volume instead of passing the password via an environment variable.

• Comment: hetzner-final-dump.sh - Verification integrity (size) (cr-comment:v1:e653ff113151d3d9450911e5)

• Priority: nice-to-have

• Decision: accept

• Rationale: Added a size comparison between the local dump and the uploaded GCS object to verify integrity beyond simple existence.