Skip to content
Ordermatic Docs

ADR — PR #2007

2026-07-01 14:40 — Move query param cleanup outside the toast condition

Section titled “2026-07-01 14:40 — Move query param cleanup outside the toast condition”
  • Comment: Inline comment on apps/webapp/src/pages/inbox.astro
  • Priority: must-fix
  • Decision: accept
  • Rationale: If a user revisits the URL with the parameter later, the toast correctly won’t show again, but the URL won’t be cleaned up either. Moving the cleanup outside the hasSeen branch ensures the parameter is always stripped.

2026-07-01 14:40 — Update toast dismiss test to use concrete affordance

Section titled “2026-07-01 14:40 — Update toast dismiss test to use concrete affordance”
  • Comment: cr-comment:v1:b5ae9d60bfea3cdd18402bfb
  • Priority: nice-to-have
  • Decision: accept
  • Rationale: Relying on an implicit click/timeout to dismiss the toast is flaky. Using the explicit close button ensures the test is robust.

2026-07-01 14:40 — Remove redundant window check

Section titled “2026-07-01 14:40 — Remove redundant window check”
  • Comment: cr-comment:v1:598026af0deae2d9660b7fcc
  • Priority: nice-to-have
  • Decision: accept
  • Rationale: Astro <script> blocks run only on the client side, so the typeof window check is dead code. Removing it cleans up the logic.