Skip to content
Ordermatic Docs

ADR — PR #2077

2026-07-03 16:30 — Escape credentials in Eclipse E4 SOAP requests

Section titled “2026-07-03 16:30 — Escape credentials in Eclipse E4 SOAP requests”
  • Comment: CodeRabbit review on eclipse-e4-service.ts
  • Priority: must-fix
  • Decision: accept
  • Rationale: Escaping XML prevents potential request malformation and injection vulnerabilities when credentials contain special characters.

2026-07-03 16:30 — Explicit error throwing for missing WhereFour credentials

Section titled “2026-07-03 16:30 — Explicit error throwing for missing WhereFour credentials”
  • Comment: CodeRabbit review on wherefour-service.ts (Around line 165-171)
  • Priority: must-fix
  • Decision: accept
  • Rationale: Failing explicitly instead of silently omitting the Authorization header avoids ambiguous 401s and empty search results.

2026-07-03 16:30 — Hoist auth-header resolution in WhereFour service

Section titled “2026-07-03 16:30 — Hoist auth-header resolution in WhereFour service”
  • Comment: CodeRabbit review on wherefour-service.ts (Line 318, 1065)
  • Priority: nice-to-have
  • Decision: accept
  • Rationale: Extracting getAuthHeaders from broad try/catch blocks and loops ensures configuration errors are not silently swallowed and reduces redundant Infisical credential retrievals.