Skip to content
Ordermatic Docs

ADR — PR #1097

2026-05-22 07:45 — Add _BUILD_* early-exit guards to Docker build steps

Section titled “2026-05-22 07:45 — Add _BUILD_* early-exit guards to Docker build steps”
  • Comment: CodeRabbit nitpick on cloudbuild-workers.yaml lines 74-93
  • Priority: nice-to-have
  • Decision: accept
  • Rationale: The docker-build-temporal-worker and docker-build-dagster steps were missing early-exit guards for _BUILD_TEMPORAL_WORKER and _BUILD_DAGSTER respectively, so the full Docker build ran even when those flags were false. Added the same if [ "${_BUILD_*}" != "true" ]; then echo "... build disabled — skipping"; exit 0; fi pattern used by the push and deploy steps, making partial/manual runs faster and matching the flag semantics.

2026-05-22 10:45 — Honor BUILD* flags in docker build steps

Section titled “2026-05-22 10:45 — Honor BUILD* flags in docker build steps”
  • Comment: CodeRabbit comment thread on PR #1097
  • Priority: must-fix
  • Decision: accept
  • Rationale: Verified that early-exit guards for _BUILD_TEMPORAL_WORKER and _BUILD_DAGSTER are present and correct, satisfying the must-fix requirement.