ADR — PR #1025

2026-05-19 10:00 — Replace console.error with structured logger

• Comment: https://github.com/dboone31/erp-unlocked/pull/1025#pullrequestreview-4305327736
• Priority: must-fix
• Decision: accept
• Rationale: Aligns with project logging standards using Pino logger.

2026-05-19 15:30 — Refactor to use Nanostores pattern

• Comment: https://github.com/dboone31/erp-unlocked/pull/1025#pullrequestreview-4305327736
• Priority: must-fix
• Decision: accept
• Rationale: Follows project convention for state management using Nanostores instead of React hooks.

2026-05-19 15:35 — Fix selectedOrgId reset on form open/close

• Comment: https://github.com/dboone31/erp-unlocked/pull/1025#discussion_r3254517618
• Priority: nice-to-have
• Decision: accept
• Rationale: Prevents stale org selection when opening/closing add organization form.

2026-05-19 15:40 — Debounce slider changes to prevent rapid POSTs

• Comment: https://github.com/dboone31/erp-unlocked/pull/1025#discussion_r3254517617
• Priority: nice-to-have
• Decision: accept
• Rationale: Reduces API calls and prevents race conditions by committing slider changes only on interaction end.

2026-05-19 15:45 — Ensure proper error handling in organizations fetch

• Comment: https://github.com/dboone31/erp-unlocked/pull/1025#discussion_r3254517608
• Priority: must-fix
• Decision: accept
• Rationale: Throws descriptive errors instead of silently returning, allowing proper error display in UI.

2026-05-20 15:30 — Final verification of CodeRabbit findings

• Comment: https://github.com/dboone31/erp-unlocked/pull/1025
• Priority: must-fix
• Decision: accept
• Rationale: All CodeRabbit findings addressed - console.error already fixed to Pino, Nanostores pattern properly implemented, UI state issues resolved.

2026-05-20 16:45 — Skip false positives - logging already implemented

• Comment: https://github.com/dboone31/erp-unlocked/pull/1025#pullrequestreview-4305327736
• Priority: skip
• Decision: reject
• Rationale: Code already uses proper Pino structured logging (logger.error({ err: error }, 'Feature flags API error')), finding was false positive.

2026-05-20 16:50 — Skip false positives - Nanostores pattern already implemented

• Comment: https://github.com/dboone31/erp-unlocked/pull/1025#pullrequestreview-4305327736
• Priority: skip
• Decision: reject
• Rationale: Component already correctly uses Nanostores with useStore and proper atoms/computed values, finding was false positive.

2026-05-20 16:55 — Add request token guard for slider changes

• Comment: https://github.com/dboone31/erp-unlocked/pull/1025#discussion_r3254517617
• Priority: must-fix
• Decision: accept
• Rationale: Added request token mechanism to prevent stale responses from overwriting newer flag updates during rapid slider changes.

2026-05-21 03:00 — Fix stale-response guard with useRef (PR #1080 review)

• Comment: https://github.com/dboone31/erp-unlocked/pull/1080#discussion_r3279311233
• Priority: must-fix
• Decision: accept
• Rationale: The previous request-token guard captured requestToken from the same render snapshot as currentToken, so the equality check always passed and stale responses could still overwrite newer updates. Switched to a useRef-backed token that the closure can re-read after await.

2026-05-21 03:00 — Mirror write path in parseRollout (PR #1080 review)

• Comment: https://github.com/dboone31/erp-unlocked/pull/1080#discussion_r3279311242
• Priority: must-fix
• Decision: accept
• Rationale: upsertDefaultState stores the rollout in the first multivariate variant only, so summing all variants here always produced 100%. Read the first variant so reads match writes.

2026-05-21 03:00 — Wrap flag catalog load in try/catch (PR #1080 review)

• Comment: https://github.com/dboone31/erp-unlocked/pull/1080#discussion_r3279311251
• Priority: nice-to-have
• Decision: accept
• Rationale: A missing or malformed flags.json previously surfaced as a cryptic Node error; now it throws with the resolved path and the original error attached via cause.

2026-05-21 03:00 — Don’t return raw exception messages in 500s (PR #1080 review)

• Comment: https://github.com/dboone31/erp-unlocked/pull/1080#discussion_r3279311257
• Priority: must-fix
• Decision: accept
• Rationale: Exception messages can leak internal details to clients. Return a generic message and keep diagnostics in server logs only.